tools: remove space in man pages linking regex#17479
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Removes space in regex for man pages linking in docs generation
nodejs-github-bot added doc 
lpinca approved these changes Dec 6, 2017
tools/doc/html.js Outdated
| functionlinkManPages(text){ | ||
| returntext.replace( | ||
| /([a-z.]+)\((\d)([a-z]?)\)/gm, | ||
| /([a-z.]+)\((\d)([a-z]?)\)/gm, |
maclover7 approved these changes Dec 6, 2017
jasnell approved these changes Dec 6, 2017
Member
Trott commented Dec 6, 2017
Definitely prefer it be replaced by |
Removes space in regex for man pages linking in docs generation
ContributorAuthor
DiegoRBaquero commented Dec 6, 2017
Changed to |
Trott approved these changes Dec 7, 2017
cjihrig approved these changes Dec 7, 2017
Contributor
apapirovski commented Dec 8, 2017
apapirovski pushed a commit that referenced this pull request Dec 9, 2017
PR-URL: #17479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
apapirovski commented Dec 9, 2017
Landed in ea77b33 |
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
This was referenced Dec 12, 2017
DiegoRBaquero added a commit to DiegoRBaquero/node that referenced this pull request Dec 18, 2017
The change to word boundary was breaking many doc pages. This reverts the word boundary back to space. Fixes: nodejs#17637Fixes: nodejs#17694 Refs: nodejs#17479
1 task
DiegoRBaquero added a commit to DiegoRBaquero/node that referenced this pull request Dec 19, 2017
The change to word boundary was breaking many doc pages. This replace the word boundary with a matching group of space or beginning of line. Fixes: nodejs#17637Fixes: nodejs#17694 Refs: nodejs#17479
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
The change to word boundary was breaking many doc pages. This reverts the word boundary back to space. PR-URL: #17724Fixes: #17694 Refs: #17479 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
The change to word boundary was breaking many doc pages. This reverts the word boundary back to space. PR-URL: #17724Fixes: #17694 Refs: #17479 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
The change to word boundary was breaking many doc pages. This reverts the word boundary back to space. PR-URL: #17724Fixes: #17694 Refs: #17479 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
The change to word boundary was breaking many doc pages. This reverts the word boundary back to space. PR-URL: #17724Fixes: #17694 Refs: #17479 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
The change to word boundary was breaking many doc pages. This reverts the word boundary back to space. PR-URL: #17724Fixes: #17694 Refs: #17479 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes space in regex for man pages linking in docs generation
Checklist
Affected core subsystem(s)
tools
Stumbled upon signal(7) no being linked in child_process because in the markdown file it happens to be the start of the line, so there's no space.