Skip to content

refactor: replace assert.throws in tests with common.expectsError#17483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mithunsasidharan wants to merge 1 commit into from
Closed

refactor: replace assert.throws in tests with common.expectsError #17483

mithunsasidharan wants to merge 1 commit into from

Conversation

@mithunsasidharan
Copy link
Contributor

@mithunsasidharanmithunsasidharan commented Dec 6, 2017•
edited
Loading

Refactored tests to replace assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); in following test files :

  • test/parallel/test-async-hooks-asyncresource-constructor.js
  • test/parallel/test-async-wrap-constructor.js
  • test/parallel/test-buffer-alloc.js
  • test/parallel/test-buffer-arraybuffer.js
  • test/parallel/test-buffer-compare-offset.js
  • test/parallel/test-buffer-compare.js
  • test/parallel/test-buffer-concat.js
  • test/parallel/test-buffer-fill.js
  • test/parallel/test-buffer-new.js
  • test/parallel/test-buffer-read.js
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 6, 2017
evanlucas
evanlucas approved these changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@evanlucasevanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

CI: https://ci.nodejs.org/job/node-test-pull-request/11910/

@mithunsasidharanmithunsasidharan mentioned this pull request Dec 8, 2017
Closed
3 tasks
@apapirovski
Copy link
Contributor

apapirovski commented Dec 8, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11986/

Was a little wonky last time, double-checking.

@apapirovski
Copy link
Contributor

apapirovski commented Dec 8, 2017

Landed in 146a9b1

apapirovski pushed a commit that referenced this pull request Dec 8, 2017
@mithunsasidharan@apapirovski
test: replace assert.throws w/ common.expectsError
146a9b1
PR-URL: #17483 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan@MylesBorins
test: replace assert.throws w/ common.expectsError
faae2ce
PR-URL: #17483 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan@MylesBorins
test: replace assert.throws w/ common.expectsError
ff59d3a
PR-URL: #17483 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@cjihrigcjihrigcjihrig approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+1 more reviewer

@evanlucasevanlucasevanlucas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mithunsasidharan@apapirovski@jasnell@evanlucas@cjihrig@BridgeAR@gibfahn@nodejs-github-bot