util: fix negative 0 check in inspect#17507
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the util 
refack approved these changes Dec 6, 2017
lib/util.js Outdated
Contributor
There was a problem hiding this comment.
The performance concern is real (3x slower for Object.is) but does it really matter in this case? It feels like this might be a micro-optimization too far.
Member
There was a problem hiding this comment.
It got better recently but those changes may not be in 6.3 yet. And yeah, I don't think Object.is() is going to be the expensive part here.
apapirovski approved these changes Dec 6, 2017
lib/util.js Outdated
Contributor
There was a problem hiding this comment.
The comment should be adjusted if this is being changed to Object.is again.
lib/util.js Outdated
Contributor
There was a problem hiding this comment.
Sorry, I was thinking something more along the lines of:
// Format -0 as '-0'. A `value === -0` check won't distinguish 0 from -0. We don't really need to talk about the performance of it, IMHO.
bnoordhuis approved these changes Dec 6, 2017
cjihrig approved these changes Dec 7, 2017
XadillaX approved these changes Dec 7, 2017
lpinca approved these changes Dec 7, 2017
BridgeAR requested changes Dec 7, 2017
Member
BridgeAR left a comment
BridgeAR left a comment There was a problem hiding this comment.
LGTM but we definitely should add a test before landing.
Contributor
apapirovski commented Dec 8, 2017
@BridgeAR would you mind reviewing this? It appears your feedback might've been addressed. Thank you! |
BridgeAR approved these changes Dec 8, 2017
addaleax approved these changes Dec 8, 2017
addaleax added the author ready 
Member
addaleax commented Dec 8, 2017
refack approved these changes Dec 8, 2017
Contributor
apapirovski commented Dec 9, 2017
Landed in 86527bd |
apapirovski pushed a commit that referenced this pull request Dec 9, 2017
PR-URL: #17507 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17507 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17507 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
addaleax removed the author ready 
Member
gibfahn commented Dec 20, 2017
Should this be backported to |
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17507 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17507 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#17500
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util