test: fix flaky async-hooks/test-graph.signal#17509
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added async_hooks 
nodejs-github-bot added async_hooks 
Make sure event loop remains open long enough for signal to be received. Fixes: nodejs#14568
MemberAuthor
Stress test on master showing failures (although only 2 failures in 19200 runs): Stress test with this PR: https://ci.nodejs.org/job/node-stress-single-test/1561/nodes=centos7-64/console |
MemberAuthor
Trott commented Dec 6, 2017
Stress test came back green! Removing the |
MemberAuthor
Trott commented Dec 7, 2017
MemberAuthor
Trott commented Dec 7, 2017
Lint error appears to be caused by #17460 and unrelated to this. |
MemberAuthor
Trott commented Dec 7, 2017
Running CI again now that linter has been unbroken. Unrelated build failure on macOS too, so canceled the whole thing and starting again... |
cjihrig approved these changes Dec 7, 2017
richardlau approved these changes Dec 7, 2017
MemberAuthor
Trott commented Dec 7, 2017
CI failures are two known unrelated flaky tests and a build failure. Re-running the build failure: https://ci.nodejs.org/job/node-test-commit-linuxone/10970/ |
refack approved these changes Dec 7, 2017
evanlucas approved these changes Dec 8, 2017
Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2017
Make sure event loop remains open long enough for signal to be received. PR-URL: nodejs#17509Fixes: nodejs#14568 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
MemberAuthor
Trott commented Dec 8, 2017
Landed in 8997026 |
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Make sure event loop remains open long enough for signal to be received. PR-URL: #17509Fixes: #14568 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Make sure event loop remains open long enough for signal to be received. PR-URL: #17509Fixes: #14568 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Make sure event loop remains open long enough for signal to be received. PR-URL: #17509Fixes: #14568 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
Make sure event loop remains open long enough for signal to be received. PR-URL: #17509Fixes: #14568 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
Make sure event loop remains open long enough for signal to be received. PR-URL: #17509Fixes: #14568 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure event loop remains open long enough for signal to be received.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test async-hooks