src: remove unused include node_crypto_clienthello#17546
Closed
+1 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit removes the include of node.h which does not seem to be used.
nodejs-github-bot added c++ 
ContributorAuthor
danbev commented Dec 8, 2017
bnoordhuis approved these changes Dec 8, 2017
ContributorAuthor
danbev commented Dec 8, 2017
cjihrig approved these changes Dec 11, 2017
ContributorAuthor
danbev commented Dec 11, 2017
Landed in 7bb2cc4. |
danbev added a commit that referenced this pull request Dec 11, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be used. PR-URL: #17546 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the include of node.h which does not seem to be
used.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
crypto