refactor: intuitively handle current object context#17553
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
maclover7 commented Dec 8, 2017
Can you please update the commit message to follow the commit guidelines |
ContributorAuthor
mithunsasidharan commented Dec 9, 2017
@maclover7 : Thanks for the feedback. I'm not quite sure what you were referring to exactly in commit message that needs to be updated. Kindly advice. Thanks. |
Contributor
apapirovski commented Dec 9, 2017
@mithunsasidharan The commit messages should start with the subsystem being worked on, so in this case "test". See the link above. |
ContributorAuthor
mithunsasidharan commented Dec 9, 2017
@apapirovski : Thanks for pointing that out. I've updated the commit message. I hope the PR can be left the same. Kindly advice. |
maclover7 approved these changes Dec 9, 2017
Contributor
maclover7 commented Dec 9, 2017
mithunsasidharan changed the title 
lpinca approved these changes Dec 11, 2017
maclover7 added the author ready Contributor
maclover7 commented Dec 11, 2017
Landing... |
Contributor
maclover7 commented Dec 11, 2017
Thank you for your contribution, landed in f3aaaa5. |
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17553 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17553 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
addaleax removed the author ready gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17553 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17553 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17553 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored to intuitively handle current object context
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test