tools,test: throw if common.PORT used in parallel tests#17559
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added test 
lpinca approved these changes Dec 9, 2017
Trott added the python 
MemberAuthor
Trott commented Dec 9, 2017
test/testpy/__init__.py Outdated
Contributor
There was a problem hiding this comment.
Can env and the later .format() call be removed now, since env is now empty? For reference, was introduced in 782620f.
MemberAuthor
There was a problem hiding this comment.
@maclover7 Sure seems like it. Will rebase, make that change, test, and force push....
common.PORT is no longer used in parallelized tests and should not be. Remove code that accommodates parallelized tests.
common.PORT should not be used in parallelized tests. (There can be a port collision if another tests requests an arbitrary open port from the operating system and ends up getting common.PORT before a test that uses common.PORT uses the port.) In such a situation, throw an error.
MemberAuthor
Trott commented Dec 9, 2017
gibfahn approved these changes Dec 10, 2017
MemberAuthor
Trott commented Dec 10, 2017
MemberAuthor
Re-running Linux CI only just to make sure the Fedora 24 issue is only the usual flaky test (got a PR in to fix one of 'em already): https://ci.nodejs.org/job/node-test-commit-linux/14880/ |
Trott added a commit to Trott/io.js that referenced this pull request Dec 12, 2017
common.PORT is no longer used in parallelized tests and should not be. Remove code that accommodates parallelized tests. PR-URL: nodejs#17559 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Dec 12, 2017
common.PORT should not be used in parallelized tests. (There can be a port collision if another tests requests an arbitrary open port from the operating system and ends up getting common.PORT before a test that uses common.PORT uses the port.) In such a situation, throw an error. PR-URL: nodejs#17559 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MemberAuthor
Trott commented Dec 12, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
common.PORT is no longer used in parallelized tests and should not be. Remove code that accommodates parallelized tests. PR-URL: #17559 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
common.PORT should not be used in parallelized tests. (There can be a port collision if another tests requests an arbitrary open port from the operating system and ends up getting common.PORT before a test that uses common.PORT uses the port.) In such a situation, throw an error. PR-URL: #17559 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
common.PORT is no longer used in parallelized tests and should not be. Remove code that accommodates parallelized tests. PR-URL: #17559 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
common.PORT should not be used in parallelized tests. (There can be a port collision if another tests requests an arbitrary open port from the operating system and ends up getting common.PORT before a test that uses common.PORT uses the port.) In such a situation, throw an error. PR-URL: #17559 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Merged
Member
Could this be backported to v6.x and |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common.PORT should not be used in parallelized tests. (There can be a
port collision if another tests requests an arbitrary open port from the
operating system and ends up getting common.PORT before a test that uses
common.PORT uses the port.) In such a situation, throw an error.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test tools