assert: fix .throws operator#17575
Closed
assert: fix .throws operator #17575
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the assert 4 tasks
cjihrig approved these changes Dec 10, 2017
MemberAuthor
BridgeAR commented Dec 12, 2017
While thinking about it again and before I merge it - one alternative would be to use |
jasnell approved these changes Dec 12, 2017
Member
Trott commented Dec 13, 2017
Contributor
cjihrig commented Dec 13, 2017
No strong opinion. |
assert.throws and assert.doesNotThrow set the operator to a internal function. That was by accident and originally the operator was undefined. This changes it to show "throws" or "doesNotThrow".
BridgeARforce-pushed the fix-assert-operator branch from 20878e3 to b3da103CompareMemberAuthor
BridgeAR commented Dec 15, 2017
I decided to add the operator. In case a error is caught it is immediately clear what function triggered the error by looking the operator in that case. |
MemberAuthor
BridgeAR commented Dec 15, 2017
BridgeAR added the author ready 
apapirovski approved these changes Dec 15, 2017
MemberAuthor
BridgeAR commented Dec 15, 2017
Landed in a6788b4 |
BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 15, 2017
assert.throws and assert.doesNotThrow set the operator to a internal function. That was by accident and originally the operator was undefined. This changes it to show "throws" or "doesNotThrow". PR-URL: nodejs#17575 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
addaleax removed the author ready MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
assert.throws and assert.doesNotThrow set the operator to a internal function. That was by accident and originally the operator was undefined. This changes it to show "throws" or "doesNotThrow". PR-URL: #17575 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
Contributor
MylesBorins commented Jan 23, 2018
should this be backported? My gut is saying no, but I'm not 100% |
This comment has been minimized.
This comment has been minimized.
Contributor
MylesBorins commented May 22, 2018
ping re: backport |
Contributor
MylesBorins commented Jun 20, 2018
ping @BridgeAR |
BridgeAR added a commit to BridgeAR/node that referenced this pull request Oct 2, 2018
assert.throws and assert.doesNotThrow set the operator to a internal function. That was by accident and originally the operator was undefined. This changes it to show "throws" or "doesNotThrow". PR-URL: nodejs#17575 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 31, 2018
assert.throws and assert.doesNotThrow set the operator to a internal function. That was by accident and originally the operator was undefined. This changes it to show "throws" or "doesNotThrow". Backport-PR-URL: #23223 PR-URL: #17575 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert.throws and assert.doesNotThrow set the operator to a
internal function. That was actually not intended as the operator
is not defined at all in those cases.
CI https://ci.nodejs.org/job/node-test-pull-request/12003/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
assert