Skip to content

tools: simplify lowercase-name-for-primitive rule#17653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjihrig merged 1 commit into from
Dec 15, 2017
Merged

tools: simplify lowercase-name-for-primitive rule #17653

cjihrig merged 1 commit into from
Dec 15, 2017

Conversation

@cjihrig
Copy link
Contributor

@cjihrigcjihrig commented Dec 13, 2017

  • Use an AST selector instead of handwritten function.
  • Move functions up a scope level.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 13, 2017
maclover7
maclover7 approved these changes Dec 13, 2017
View reviewed changes
Copy link
Contributor

@maclover7maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maclover7
Copy link
Contributor

maclover7 commented Dec 13, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12089/

@BridgeARBridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 13, 2017
@cjihrig
Copy link
ContributorAuthor

cjihrig commented Dec 15, 2017

New CI run: https://ci.nodejs.org/job/node-test-pull-request/12128/

@cjihrig
tools: simplify lowercase-name-for-primitive rule
203ce5f
PR-URL: nodejs#17653 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
@cjihrigcjihrig merged commit 203ce5f into nodejs:masterDec 15, 2017
@cjihrigcjihrig deleted the lint branch December 15, 2017 16:21
@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@cjihrig@MylesBorins
tools: simplify lowercase-name-for-primitive rule
eaa2d91
PR-URL: #17653 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@cjihrig@MylesBorins
tools: simplify lowercase-name-for-primitive rule
de5130d
PR-URL: #17653 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@cjihrig@MylesBorins
tools: simplify lowercase-name-for-primitive rule
57e4cfd
PR-URL: #17653 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@cjihrig@gibfahn
tools: simplify lowercase-name-for-primitive rule
59def2a
PR-URL: #17653 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@cjihrig@MylesBorins
tools: simplify lowercase-name-for-primitive rule
244d569
PR-URL: #17653 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@cjihrig@MylesBorins
tools: simplify lowercase-name-for-primitive rule
4553859
PR-URL: #17653 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@cjihrig@MylesBorins
tools: simplify lowercase-name-for-primitive rule
928b7c8
PR-URL: #17653 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+2 more reviewers

@apapirovskiapapirovskiapapirovski approved these changes

@maclover7maclover7maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@cjihrig@maclover7@apapirovski@jasnell@lpinca@BridgeAR@MylesBorins@addaleax@nodejs-github-bot