Skip to content

test: change callback function to arrow function#17699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
skanamaru wants to merge 1 commit into from
Closed

test: change callback function to arrow function #17699

skanamaru wants to merge 1 commit into from

Conversation

@skanamaru
Copy link
Contributor

@skanamaruskanamaru commented Dec 15, 2017

I'd like to send to pull request.
I change callback function to arrow function.

This is practice on code-and-learn for contributing oss.
nodejs/code-and-learn#78

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 15, 2017
@gireeshpunathilgireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 15, 2017
@maclover7
Copy link
Contributor

maclover7 commented Dec 15, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12132/

@BridgeARBridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 15, 2017
@BridgeAR
Copy link
Member

BridgeAR commented Dec 15, 2017

Landed in 37d2773

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Dec 15, 2017
@skanamaru@BridgeAR
test: change callback function to arrow function
37d2773
PR-URL: nodejs#17699 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Dec 15, 2017

@skanamaru congratulations on your first commit to Node.js! 🎉

@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@skanamaru@MylesBorins
test: change callback function to arrow function
90e3161
PR-URL: #17699 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@skanamaru@MylesBorins
test: change callback function to arrow function
a9d83ce
PR-URL: #17699 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@skanamaru@MylesBorins
test: change callback function to arrow function
49d2b29
PR-URL: #17699 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2018
@skanamaru@MylesBorins
test: change callback function to arrow function
b6c65af
PR-URL: #17699 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
@skanamaru@gibfahn
test: change callback function to arrow function
c81b851
PR-URL: #17699 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@skanamaru@MylesBorins
test: change callback function to arrow function
6981fda
PR-URL: #17699 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@skanamaru@MylesBorins
test: change callback function to arrow function
e0671e4
PR-URL: #17699 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@skanamaru@MylesBorins
test: change callback function to arrow function
2d77241
PR-URL: #17699 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes

@tniessentniessentniessen approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+2 more reviewers

@yosuke-furukawayosuke-furukawayosuke-furukawa approved these changes

@maclover7maclover7maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@skanamaru@maclover7@BridgeAR@yosuke-furukawa@cjihrig@tniessen@gireeshpunathil@MylesBorins@addaleax@nodejs-github-bot