Skip to content

src: remove unused async hooks methods#17757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
addaleax wants to merge 1 commit into from
Closed

src: remove unused async hooks methods #17757

addaleax wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

@addaleaxaddaleax commented Dec 19, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 19, 2017
@addaleaxaddaleax added the async_hooks Issues and PRs related to the async hooks subsystem. label Dec 19, 2017
maclover7
maclover7 approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@maclover7maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is OK

@maclover7
Copy link
Contributor

maclover7 commented Dec 19, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12209/

@addaleax
Copy link
MemberAuthor

addaleax commented Dec 20, 2017

Landed in 482c27e

@addaleaxaddaleax deleted the async-unused branch December 20, 2017 06:06
addaleax added a commit that referenced this pull request Dec 20, 2017
@addaleax
src: remove unused async hooks methods
482c27e
PR-URL: #17757 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: vdeturckheim <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@addaleax@MylesBorins
src: remove unused async hooks methods
d93c57a
PR-URL: #17757 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: vdeturckheim <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@addaleax@MylesBorins
src: remove unused async hooks methods
99c62cc
PR-URL: #17757 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: vdeturckheim <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jan 10, 2018
Merged
@AndreasMadsenAndreasMadsen mentioned this pull request Jan 16, 2018
Closed
4 tasks
gibfahn pushed a commit to gibfahn/node that referenced this pull request Jan 17, 2018
@addaleax@gibfahn
src: remove unused async hooks methods
8e8d0b3
PR-URL: nodejs#17757 Backport-PR-URL: nodejs#18179 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: vdeturckheim <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2018
@addaleax@MylesBorins
src: remove unused async hooks methods
089f18e
Backport-PR-URL: #18179 PR-URL: #17757 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: vdeturckheim <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@cjihrigcjihrigcjihrig approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+6 more reviewers

@apapirovskiapapirovskiapapirovski approved these changes

@danbevdanbevdanbev approved these changes

@TimothyGuTimothyGuTimothyGu approved these changes

@maclover7maclover7maclover7 approved these changes

@hiroppyhiroppyhiroppy approved these changes

@vdeturckheimvdeturckheimvdeturckheim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@addaleax@maclover7@apapirovski@danbev@jasnell@TimothyGu@cjihrig@hiroppy@vdeturckheim@BridgeAR@AndreasMadsen@BethGriggs@nodejs-github-bot