crypto: throw on invalid authentication tag length#17825
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
MemberAuthor
tniessen commented Dec 22, 2017
cc @nodejs/crypto @willclarktech |
tniessen added notable-change tniessenforce-pushed the throw-auth-tag-length branch 2 times, most recently from 42d00bb to dc0f9f0CompareMemberAuthor
tniessen commented Jan 5, 2018
ping @nodejs/crypto |
bnoordhuis approved these changes Jan 5, 2018
MemberAuthor
tniessen commented Jan 6, 2018
ping @nodejs/tsc as this is a semver-major change |
joyeecheung approved these changes Jan 6, 2018
src/node_crypto.cc Outdated
Member
There was a problem hiding this comment.
I would prefer keeping the invalid tag_len in the message for debuggability, but it's not blocking.
Member
By the way, the original deprecation does not seem to appear in |
MemberAuthor
tniessen commented Jan 6, 2018
That's a good idea, I will open a PR. |
tniessenforce-pushed the throw-auth-tag-length branch from 5a09d9f to 5debc52Compare4 tasks
jasnell approved these changes Jan 6, 2018
This was referenced Jan 21, 2018
Member
targos commented Feb 3, 2018
What is blocking this? |
MemberAuthor
tniessen commented Feb 4, 2018
tniessenforce-pushed the throw-auth-tag-length branch from 5debc52 to 6ee8771Compare
tniessenforce-pushed the throw-auth-tag-length branch from 6ee8771 to 2e68afcCompareMemberAuthor
tniessen commented Apr 13, 2018
MemberAuthor
tniessen commented Apr 13, 2018
@joyeecheung PTAL :) |
joyeecheung approved these changes Apr 14, 2018
Member
jasnell commented Apr 14, 2018
Failure in CI is unrelated. |
Member
jasnell commented Apr 14, 2018
I'm going to land this but I'm not going to pull it in to 10.x |
jasnell pushed a commit that referenced this pull request Apr 14, 2018
Refs: #17523 PR-URL: #17825 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 14, 2018
PR-URL: #17825 Refs: #17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 14, 2018
PR-URL: #17825 Refs: #17523 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Apr 14, 2018
MemberAuthor
tniessen commented Apr 14, 2018
@jasnell Thank you, this was part of the 11.0.0 milestone and was not supposed to land on node 10 :) |
2 tasks
tniessen added a commit to tniessen/node that referenced this pull request May 23, 2018
The current implementation performs limited checks only and silently ignores superfluous bytes of the authentication tag. This change makes setAuthTag throw when - the user-specified authTagLength does not match the actual tag length, especially when the authentication tag is longer than 16 bytes, and when - the mode is GCM, no authTagLength option has been specified and the tag length is not a valid GCM tag length. This change makes the conditional assignment in SetAuthTag unnecessary, which is replaced with a CHECK. Refs: nodejs#17825
tniessen added a commit that referenced this pull request Jun 1, 2018
The current implementation performs limited checks only and silently ignores superfluous bytes of the authentication tag. This change makes setAuthTag throw when - the user-specified authTagLength does not match the actual tag length, especially when the authentication tag is longer than 16 bytes, and when - the mode is GCM, no authTagLength option has been specified and the tag length is not a valid GCM tag length. This change makes the conditional assignment in SetAuthTag unnecessary, which is replaced with a CHECK. Refs: #17825 PR-URL: #20040 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Yihong Wang <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
3 tasks
targos pushed a commit that referenced this pull request Jun 24, 2018
Given that #17825 and #20039 have landed on master, this statement is no longer true. PR-URL: #21445 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #17566.
Refs: #17523
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
crypto