Skip to content

src: use AliasedBuffer for TickInfo#17881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
apapirovski wants to merge 1 commit into from
Closed

src: use AliasedBuffer for TickInfo #17881

apapirovski wants to merge 1 commit into from

Conversation

@apapirovski
Copy link
Contributor

@apapirovskiapapirovski commented Dec 27, 2017

Instead of creating a v8::ArrayBuffer in SetupNextTick, instead just make TickInfo use an AliasedBuffer. The reason it wasn't already doing this is that the code there predates the introduction of AliasedBuffer.

Also slight clean up around the naming of the "scheduled" flag.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@apapirovskiapapirovski added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 27, 2017
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels Dec 27, 2017
@addaleax
Copy link
Member

addaleax commented Dec 27, 2017

Sorry, the commits I just landed might have given you an immediate merge conflict? :/

@apapirovskiapapirovskiforce-pushed the patch-tickinfo-aliasedbuffer branch from aefac2c to b31bf75CompareDecember 27, 2017 18:59
@apapirovski
Copy link
ContributorAuthor

apapirovski commented Dec 27, 2017

@addaleax No worries, just rebased.

CI: https://ci.nodejs.org/job/node-test-pull-request/12317/

@apapirovskiapapirovski changed the title src: use AliasedBufer for TickInfosrc: use AliasedBuffer for TickInfoDec 27, 2017
@apapirovskiapapirovskiforce-pushed the patch-tickinfo-aliasedbuffer branch from b31bf75 to 26fdc0fCompareDecember 27, 2017 19:03
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 27, 2017
bnoordhuis
bnoordhuis approved these changes Dec 27, 2017
View reviewed changes
Copy link
Member

@bnoordhuisbnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scheduled -> hasScheduled thing is a stylistic change and should arguably be done in a separate commit.

I'm not fond of returning mutable references but I know other places that use AliasedBuffer do the same thing. We should rectify that sometime soon.

XadillaX
XadillaX approved these changes Dec 28, 2017
View reviewed changes
Copy link
Contributor

@XadillaXXadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apapirovski
Copy link
ContributorAuthor

apapirovski commented Dec 31, 2017

Landed in 5846786

@apapirovskiapapirovski deleted the patch-tickinfo-aliasedbuffer branch December 31, 2017 00:14
apapirovski added a commit that referenced this pull request Dec 31, 2017
@apapirovski
src: use AliasedBuffer for TickInfo
5846786
PR-URL: #17881 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorins
Copy link
Contributor

MylesBorins commented Jan 9, 2018

This does not land cleanly on v9.x, could it be backproted?

@TimothyGuTimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2018
@apapirovskiapapirovski mentioned this pull request Jan 31, 2018
Closed
3 tasks
apapirovski added a commit to apapirovski/node that referenced this pull request Feb 26, 2018
@apapirovski
src: use AliasedBuffer for TickInfo
528ca8d
PR-URL: nodejs#17881 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 26, 2018
@apapirovski@addaleax
src: use AliasedBuffer for TickInfo
d82efdb
Backport-PR-URL: #19006 PR-URL: #17881 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 26, 2018
@apapirovski@addaleax
src: use AliasedBuffer for TickInfo
eaf8ae5
Backport-PR-URL: #19006 PR-URL: #17881 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 26, 2018
@apapirovski@MylesBorins
src: use AliasedBuffer for TickInfo
07c6fb9
Backport-PR-URL: #19006 PR-URL: #17881 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@addaleaxaddaleax mentioned this pull request Feb 27, 2018
Closed
@MylesBorins
Copy link
Contributor

MylesBorins commented Jul 31, 2018

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@tniessentniessentniessen approved these changes

+1 more reviewer

@XadillaXXadillaXXadillaX approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@apapirovski@addaleax@MylesBorins@bnoordhuis@jasnell@XadillaX@tniessen@TimothyGu@nodejs-github-bot