Skip to content

src: silence http2 -Wunused-result warnings#17954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjihrig merged 1 commit into from
Jan 4, 2018
Merged

src: silence http2 -Wunused-result warnings #17954

cjihrig merged 1 commit into from
Jan 4, 2018

Conversation

@cjihrig
Copy link
Contributor

@cjihrigcjihrig commented Jan 2, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Jan 2, 2018
@cjihrig
Copy link
ContributorAuthor

cjihrig commented Jan 4, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12404/

@cjihrig
src: silence http2 -Wunused-result warnings
0a84263
PR-URL: nodejs#17954 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@cjihrigcjihrig merged commit 0a84263 into nodejs:masterJan 4, 2018
@cjihrigcjihrig deleted the warnings branch January 4, 2018 16:17
MylesBorins pushed a commit to jasnell/node that referenced this pull request Jan 9, 2018
@cjihrig@MylesBorins
src: silence http2 -Wunused-result warnings
c1c4a6c
PR-URL: nodejs#17954 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@cjihrig@MylesBorins
src: silence http2 -Wunused-result warnings
6cbe1b0
Backport-PR-URL: #18050 PR-URL: #17954 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@cjihrig@MylesBorins
src: silence http2 -Wunused-result warnings
f9c84c5
Backport-PR-URL: #18050 PR-URL: #17954 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@cjihrig@kjin
src: silence http2 -Wunused-result warnings
098d052
Backport-PR-URL: nodejs#18050 PR-URL: nodejs#17954 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@cjihrig@MylesBorins
src: silence http2 -Wunused-result warnings
3766e04
Backport-PR-URL: #18050 Backport-PR-URL: #20456 PR-URL: #17954 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@addaleaxaddaleaxaddaleax approved these changes

+1 more reviewer

@apapirovskiapapirovskiapapirovski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cjihrig@apapirovski@jasnell@addaleax@nodejs-github-bot