Skip to content

Conversation

@Trott
Copy link
Member

@TrottTrott commented Jan 5, 2018

Fixes: #17986

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@TrottTrott added test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem. labels Jan 5, 2018
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jan 5, 2018
@Trott
Copy link
MemberAuthor

Trott commented Jan 5, 2018

ping @MylesBorins (who wrote this test case in 241eb6122ee)

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 5, 2018
@Trott
Copy link
MemberAuthor

Trott commented Jan 5, 2018

jasnell pushed a commit that referenced this pull request Jan 10, 2018
PR-URL: #17988Fixes: #17986 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@jasnell
Copy link
Member

Landed in bf2e964

@jasnelljasnell closed this Jan 10, 2018
evanlucas pushed a commit that referenced this pull request Jan 22, 2018
PR-URL: #17988Fixes: #17986 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
PR-URL: #17988Fixes: #17986 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@evanlucasevanlucas mentioned this pull request Jan 30, 2018
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
PR-URL: #17988Fixes: #17986 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
PR-URL: #17988Fixes: #17986 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
This was referenced Feb 27, 2018
@TrottTrott deleted the reduce-mem-footprint branch January 13, 2022 22:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.zlibIssues and PRs related to the zlib subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

please use less memory in test-zlib

9 participants

@Trott@jasnell@lpinca@cjihrig@gireeshpunathil@BridgeAR@gibfahn@MylesBorins@nodejs-github-bot