deps: cherry-pick 0c35b72 from upstream V8

[devsnek]

cherry pick a fix for v8::Module::GetModuleNamespace for #17560

Original commit message:

[api,modules] Allow GetModuleNamespace on unevaluated modules. Bug: v8:7217 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I97b067254355eb91e12b92eba92631cbc3ce8000 Reviewed-on: https://chromium-review.googlesource.com/839280 Commit-Queue: Georg Neis <[email protected]> Reviewed-by: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/master@{#50395} 

Refs: v8/v8@0c35b72

Checklist

• commit message follows commit guidelines

Affected core subsystem(s)

deps/v8

[addaleax]

Can you try to use commit messages similar to the ones for other V8 cherry-picks, like d1d6b54 ? It would be nice to have the original commit message + a Refs: link to the V8 commit in it.

[targos]

You can use this as the commit message:

deps: cherry-pick 0c35b72 from upstream V8 Original commit message: [api,modules] Allow GetModuleNamespace on unevaluated modules. Bug: v8:7217 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I97b067254355eb91e12b92eba92631cbc3ce8000 Reviewed-on: https://chromium-review.googlesource.com/839280 Commit-Queue: Georg Neis <[email protected]> Reviewed-by: Adam Klein <[email protected]> Cr-Commit-Position: refs/heads/master@{#50395} Refs: https://github.com/v8/v8/commit/0c35b7252aaeedf4871a78935075808439726853 

[devsnek]

@addaleax done

[targos]

The commit should also update v8_embedder_string in common.gypi.

[devsnek]

@targos is there somewhere that details this process? i thought i read one somewhere a while ago but i couldn't find any documentation while making this pr.

[targos]

The process is detailed here: https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md

TLDR: if the patch can apply cleanly, the fastest way to create the commit is with:

npm i -g update-v8 update-v8 backport --sha=0c35b7252aaeedf4871a78935075808439726853 

This gets the patch, applies it, updates common.gypi and commits with the right message.

[targos]

CI: https://ci.nodejs.org/job/node-test-pull-request/12482/

[TimothyGu]

Landed in 4d4ef14.

[evanlucas]

Should this land on v9.x? If so, a backport PR will need to be submitted. It does not land cleanly on v9.x-staging.