Skip to content

test: replace assert.equal with assert.strictEqual#18119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shqld wants to merge 1 commit into from
Closed

test: replace assert.equal with assert.strictEqual #18119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/es-module/test-esm-dynamic-import.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ targetURL.pathname = absolutePath;
function expectErrorProperty(result, propertyKey, value){
Promise.resolve(result)
.catch(common.mustCall(error =>{
assert.equal(error[propertyKey], value);
assert.strictEqual(error[propertyKey], value);
}));
}

Expand DownExpand Up@@ -51,7 +51,7 @@ function expectOkNamespace(result){
function expectFsNamespace(result){
Promise.resolve(result)
.then(common.mustCall(ns =>{
assert.equal(typeof ns.default.writeFile, 'function');
assert.strictEqual(typeof ns.default.writeFile, 'function');
}));
}

Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/es-module-loaders/loader-shared-dep.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,6 @@ import dep from './loader-dep.js'
import assert from 'assert'

export function resolve(specifier, base, defaultResolve){
assert.equal(dep.format, 'esm');
assert.strictEqual(dep.format, 'esm');
return defaultResolve(specifier, base);
}
2 changes: 1 addition & 1 deletion test/fixtures/es-module-loaders/not-found-assert-loader.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ export async function resolve (specifier, base, defaultResolve){
await defaultResolve(specifier, base);
}
catch (e){
assert.equal(e.code, 'MODULE_NOT_FOUND');
assert.strictEqual(e.code, 'MODULE_NOT_FOUND');
return{
format: 'builtin',
url: 'fs'
Expand Down