Skip to content

Conversation

@vsemozhetbyt
Copy link
Contributor

@vsemozhetbytvsemozhetbyt commented Jan 18, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@vsemozhetbytvsemozhetbyt added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 18, 2018
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 18, 2018
@vsemozhetbyt
Copy link
ContributorAuthor

@maclover7
Copy link
Contributor

Is there a lint rule we can add for this?

@vsemozhetbyt
Copy link
ContributorAuthor

@maclover7 I am not sure. Let's cc @watilde as per #12756

@vsemozhetbyt
Copy link
ContributorAuthor

Landed in 6c76de1

vsemozhetbyt added a commit that referenced this pull request Jan 18, 2018
PR-URL: #18222 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@vsemozhetbytvsemozhetbyt deleted the doc-fix-links-2018-01-18 branch January 18, 2018 11:23
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
PR-URL: #18222 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@evanlucasevanlucas mentioned this pull request Jan 30, 2018
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
PR-URL: #18222 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18222 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18222 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@vsemozhetbyt@maclover7@jasnell@lpinca@cjihrig@MylesBorins@codebytere@nodejs-github-bot