doc: fix e.g., to e.g. in docs#18369
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vsemozhetbyt approved these changes Jan 25, 2018
vsemozhetbyt added the fast-track 
Contributor
vsemozhetbyt commented Jan 25, 2018
lpinca approved these changes Jan 25, 2018
cjihrig approved these changes Jan 25, 2018
tniessen approved these changes Jan 25, 2018
Contributor
vsemozhetbyt commented Jan 25, 2018
Landed in c016cc2 |
vsemozhetbyt pushed a commit that referenced this pull request Jan 25, 2018
PR-URL: #18369Fixes: nodejs/code-and-learn#58 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Member
Trott commented Jan 25, 2018
Whoa, that was fast. Um, I would have objected to this. The comma is correct in American usage which is what we follow in our docs. See, e.g., https://www.dailywritingtips.com/comma-after-i-e-and-e-g/. |
Contributor
vsemozhetbyt commented Jan 25, 2018
@Trott Sorry. Should I make a PR to revert it? |
Member
Trott commented Jan 25, 2018
I'd probably prefer a PR that changes |
ContributorAuthor
sreepurnajasti commented Jan 26, 2018
@Trott Agreed. I would like to take this up!! :) |
2 tasks
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
PR-URL: #18369Fixes: nodejs/code-and-learn#58 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
PR-URL: #18369Fixes: nodejs/code-and-learn#58 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18369Fixes: nodejs/code-and-learn#58 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: nodejs/code-and-learn#58
Checklist
Affected core subsystem(s)
doc