lib: micro-optimize url.resolve()#184
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
aredridel commented Dec 19, 2014
Wow, neat! |
lib/url.js Outdated
Contributor
There was a problem hiding this comment.
This is a nice trick to know about. Especially since splice is quite slow. :o
Contributor
There was a problem hiding this comment.
The indenting is a bit off here.
MemberAuthor
bnoordhuis commented Dec 19, 2014
Wait until you see the numbers for EventEmitter#removeListener(). :-) |
bnoordhuisforce-pushed the micro-optimize-url-resolve branch from d3d8577 to e12303fCompareMemberAuthor
bnoordhuis commented Dec 20, 2014
@chrisdickinson Fixed the indentation and renamed the function to spliceOne(). PTAL. |
algesten commented Dec 20, 2014
👍 |
Contributor
chrisdickinson commented Dec 20, 2014
LGTM |
Rename the url.parse() benchmark from url.js to url-parse.js. A follow-up commit is going to add another one for url.resolve(). PR-URL: nodejs#184 Reviewed-By: Chris Dickinson <[email protected]>
Replace the call to Array#splice() with a faster open-coded version that creates less garbage. Add a new benchmark to prove it. With the change applied, it scores about 5% higher and that is nothing to sneeze at. PR-URL: nodejs#184 Reviewed-By: Chris Dickinson <[email protected]>
bnoordhuisforce-pushed the micro-optimize-url-resolve branch from e12303f to aff56cdCompare
This was referenced May 26, 2021
This was referenced Jul 21, 2021
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the call to Array#splice() with a faster open-coded version
that creates less garbage.
Add a new benchmark to prove it. With the change applied, it scores
about 5% higher and that is nothing to sneeze at.
R=@chrisdickinson