doc: unify type linkification#18407
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
ContributorAuthor
vsemozhetbyt commented Jan 27, 2018
joyeecheung approved these changes Jan 27, 2018
ContributorAuthor
vsemozhetbyt commented Jan 27, 2018
Sorry, add one missing type in the second commit. CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/131/ |
vsemozhetbyt added the fast-track 
lpinca approved these changes Jan 27, 2018
maclover7 approved these changes Jan 27, 2018
cjihrig approved these changes Jan 27, 2018
vsemozhetbyt added a commit that referenced this pull request Jan 28, 2018
PR-URL: #18407 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
ContributorAuthor
vsemozhetbyt commented Jan 28, 2018
Landed in 5c8ce90 |
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
PR-URL: #18407 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
3 tasks
vsemozhetbyt added a commit that referenced this pull request Feb 6, 2018
PR-URL: #18601 Refs: #18407 Refs: #18444 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
PR-URL: nodejs#18407 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
Backport-PR-URL: #20456 PR-URL: #18407 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18407 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18601 Refs: nodejs#18407 Refs: nodejs#18444 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, tools
Two types in
http2.mdwere out of tune with the main method of custom type linkification — via type/URL map intools/doc/type-parser.js. So I've tried to unify them. I've added an 'HTTP2' prefix so they can be more clear intools/doc/type-parser.js, out of the narrow unambiguous context. I've also preserved this prefix in common links inside thehttp2.mdto save the association.These 2 new types are the only types with spaces, but this should be OK for
tools/doc/type-parser.jsparsing method.P.S. Also add one missing type in the second commit (
ServerHttp2Stream).