Skip to content

add vdeturckheim as collaborator#18432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vdeturckheim wants to merge 1 commit into from
Closed

add vdeturckheim as collaborator #18432

vdeturckheim wants to merge 1 commit into from

Conversation

@vdeturckheim
Copy link
Member

@vdeturckheimvdeturckheim commented Jan 29, 2018•
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@vdeturckheimvdeturckheim added the doc Issues and PRs related to the documentations. label Jan 29, 2018
apapirovski
apapirovski approved these changes Jan 29, 2018
View reviewed changes
Copy link
Contributor

@apapirovskiapapirovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

README.md Outdated
Copy link
Contributor

@apapirovskiapapirovskiJan 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the trailing slash for consistency?

@devsnek
Copy link
Member

devsnek commented Jan 29, 2018

something here doesn't look quite right?

@apapirovski
Copy link
Contributor

apapirovski commented Jan 29, 2018

something here doesn't look quite right?

Ah, the order of these strikes again... 😆I feel like this happens every other collaborator PR.

@TimothyGu
Copy link
Member

TimothyGu commented Jan 29, 2018

cluster: add cwd to cluster.settings

🤔

@vdeturckheim
Copy link
MemberAuthor

vdeturckheim commented Jan 29, 2018

landed in 4a49833

@vdeturckheimvdeturckheim deleted the add_vdeturckheim_as_colaborator branch January 29, 2018 17:01
vdeturckheim added a commit that referenced this pull request Jan 29, 2018
@vdeturckheim
doc: add vdeturckheim as collaborator
4a49833
PR-URL: #18432 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
@evanlucasevanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@vdeturckheim@evanlucas
doc: add vdeturckheim as collaborator
45051fa
PR-URL: #18432 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
evanlucas added a commit that referenced this pull request Jan 30, 2018
@evanlucas
2018-01-31, Version 9.5.0 (Current)
d665cf6
Notable changes: * cluster - add cwd to cluster.settings (cjihrig) [#18399](#18399) * deps - upgrade libuv to 1.19.1 (cjihrig) [#18260](#18260) * meta - add Leko to collaborators (Leko) [#18117](#18117) - add vdeturckheim as collaborator (vdeturckheim) [#18432](#18432) * n-api - expose n-api version in process.versions (Michael Dawson) [#18067](#18067) * perf_hooks - add performance.clear() (James M Snell) [#18046](#18046) * stream - avoid writeAfterEnd() while ending (陈刚) [#18170](#18170) PR-URL: #18464
evanlucas added a commit that referenced this pull request Jan 31, 2018
@evanlucas
2018-01-31, Version 9.5.0 (Current)
5072454
Notable changes: * cluster - add cwd to cluster.settings (cjihrig) [#18399](#18399) * deps - upgrade libuv to 1.19.1 (cjihrig) [#18260](#18260) * meta - add Leko to collaborators (Leko) [#18117](#18117) - add vdeturckheim as collaborator (vdeturckheim) [#18432](#18432) * n-api - expose n-api version in process.versions (Michael Dawson) [#18067](#18067) * perf_hooks - add performance.clear() (James M Snell) [#18046](#18046) * stream - avoid writeAfterEnd() while ending (陈刚) [#18170](#18170) PR-URL: #18464
evanlucas added a commit that referenced this pull request Feb 1, 2018
@evanlucas
2018-01-31, Version 9.5.0 (Current)
83d0f4c
Notable changes: * cluster - add cwd to cluster.settings (cjihrig) [#18399](#18399) * deps - upgrade libuv to 1.19.1 (cjihrig) [#18260](#18260) * meta - add Leko to collaborators (Leko) [#18117](#18117) - add vdeturckheim as collaborator (vdeturckheim) [#18432](#18432) * n-api - expose n-api version in process.versions (Michael Dawson) [#18067](#18067) * perf_hooks - add performance.clear() (James M Snell) [#18046](#18046) * stream - avoid writeAfterEnd() while ending (陈刚) [#18170](#18170) PR-URL: #18464
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@vdeturckheim@MylesBorins
doc: add vdeturckheim as collaborator
d333ba5
PR-URL: #18432 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@vdeturckheim@MylesBorins
doc: add vdeturckheim as collaborator
0776a43
PR-URL: #18432 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
This was referenced Feb 27, 2018
Closed
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@vdeturckheim@MayaLekova
doc: add vdeturckheim as collaborator
75cca70
PR-URL: nodejs#18432 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@evanlucas@MayaLekova
2018-01-31, Version 9.5.0 (Current)
6dc8400
Notable changes: * cluster - add cwd to cluster.settings (cjihrig) [nodejs#18399](nodejs#18399) * deps - upgrade libuv to 1.19.1 (cjihrig) [nodejs#18260](nodejs#18260) * meta - add Leko to collaborators (Leko) [nodejs#18117](nodejs#18117) - add vdeturckheim as collaborator (vdeturckheim) [nodejs#18432](nodejs#18432) * n-api - expose n-api version in process.versions (Michael Dawson) [nodejs#18067](nodejs#18067) * perf_hooks - add performance.clear() (James M Snell) [nodejs#18046](nodejs#18046) * stream - avoid writeAfterEnd() while ending (陈刚) [nodejs#18170](nodejs#18170) PR-URL: nodejs#18464
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes

@cjihrigcjihrigcjihrig approved these changes

+4 more reviewers

@apapirovskiapapirovskiapapirovski approved these changes

@TimothyGuTimothyGuTimothyGu approved these changes

@devsnekdevsnekdevsnek approved these changes

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vdeturckheim@devsnek@apapirovski@TimothyGu@addaleax@cjihrig@vsemozhetbyt@MylesBorins