deps: update V8 to 6.5#18453
deps: update V8 to 6.5 #18453
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added build 
CI: https://ci.nodejs.org/job/node-test-commit/15784/ Edit: new run to confirm failures: |
targos commented Jan 31, 2018
@nodejs/platform-ppc @nodejs/platform-s390 |
mhdawson commented Jan 31, 2018
MylesBorins commented Feb 1, 2018
/cc @nodejs/v8 |
hashseed commented Feb 1, 2018
You might want to cherry-pick this patch related to code caching after this lands. |
jBarz commented Feb 2, 2018
fyi, we are investigating the ppc/s390 failures |
targos commented Feb 12, 2018
Updated to 6.5.254.19 |
Edit: fixed something in the update script: |
targos commented Feb 21, 2018
Ping @jBarz any updates on ppc/s390? |
john-yan commented Feb 21, 2018
Hello @targos , |
Related, but not necessary, is this change that you might want to cherry-pick. Background is that we are changing the code caching API to be more powerful. Until V8 6.5, you had to request for cache data to be produced as part of script compilation. Now we have a new API with While the commit I mentioned updates Node.js so that the API exposed by the |
targos commented Feb 22, 2018
@john-yan thanks. I applied floated the changes for now. Let's see if everything is fixed. @hashseed thanks. I cherry-picked that commit. CI: https://ci.nodejs.org/job/node-test-pull-request/13328/ |
targos commented Feb 22, 2018
@john-yan there are still two test failures:
|
john-yan commented Feb 22, 2018
Hello @targos , ppcbe linux is not supported anymore. Just notice the unittest error, I will investigate soon. |
ofrobots commented Feb 23, 2018
@john-yan can you elaborate? If IBM is not supporting ppcbe-linux platform for Node.js anymore, we would want to make sure we (Node.js) announce dropping of support before Node 10.0 goes out the door. /cc @nodejs/build. |
richardlau commented Feb 23, 2018
john-yan commented Feb 23, 2018
@targos For the typer failure, it could also reproduce on other platforms like x64 and arm. Therefore, it may not be a s390x issue. I opened an bug report from here: https://bugs.chromium.org/p/v8/issues/detail?id=7493 |
john-yan commented Feb 26, 2018
@targos Updates on the typer error is here: https://bugs.chromium.org/p/v8/issues/detail?id=7493#c5, this patch https://chromium-review.googlesource.com/c/v8/v8/+/880982 will fix the issue. But since it's not critical, they won't probably checkpick to 6.5. |
Original commit message: [compiler] Fix typing of NumberToString operator. It must be monotone. [email protected] Bug: v8:7354 Change-Id: I08dcd3333518029eef08c074c2b91b5c20ad699e Reviewed-on: https://chromium-review.googlesource.com/880982 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Georg Neis <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#50801} Refs: v8/v8@8bfbe25
Original commit message: Use wider types for max_old_space_size and co. Make --max_old_space_size and friends work with values >= 2**31. Such values did not work reliably (or sometimes not all) due to signed integer overflow in size computations, which is UB. Fixesnodejs#18786. Bug: chromium:814138 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ibe23cef2417fd5b4a727022b8b0d4b50f1417182 Reviewed-on: https://chromium-review.googlesource.com/927063 Commit-Queue: Ben Noordhuis <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#51433} Refs: v8/v8@46c4979
PR-URL: #18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.5. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: nodejs/node-v8#34 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> PR-URL: #18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Earlier we used to produce code cache along with compile. Now V8 has added an API to request code cache. Support for producing code cache along with compile will be removed soon. PR-URL: #18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Original commit message: [inspector] Make test byte order independent Change-Id: If0fdc76170ad29b4d3dadddbb32bc87c307c04af Reviewed-on: https://chromium-review.googlesource.com/881883 Reviewed-by: Aleksey Kozyatinskiy <[email protected]> Commit-Queue: Eugene Ostroukhov <[email protected]> Cr-Commit-Position: refs/heads/master@{#50817} Refs: v8/v8@04a06c9 PR-URL: #18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Original commit message: [compiler] Fix typing of NumberToString operator. It must be monotone. [email protected] Bug: v8:7354 Change-Id: I08dcd3333518029eef08c074c2b91b5c20ad699e Reviewed-on: https://chromium-review.googlesource.com/880982 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Georg Neis <[email protected]> Cr-Commit-Position: refs/heads/master@{#50801} Refs: v8/v8@8bfbe25 PR-URL: #18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Original commit message: Use wider types for max_old_space_size and co. Make --max_old_space_size and friends work with values >= 2**31. Such values did not work reliably (or sometimes not all) due to signed integer overflow in size computations, which is UB. Fixes#18786. Bug: chromium:814138 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ibe23cef2417fd5b4a727022b8b0d4b50f1417182 Reviewed-on: https://chromium-review.googlesource.com/927063 Commit-Queue: Ben Noordhuis <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/heads/master@{#51433} Refs: v8/v8@46c4979 PR-URL: #18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos commented Mar 7, 2018
Landed in 4e86f9b...9759573 |
PR-URL: nodejs#18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs#18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.5. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: nodejs#18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
This commit updates the following postmortem metadata constant: - v8dbg_bit_field3_dictionary_map_shift - This is now v8dbg_bit_field3_is_dictionary_map_shift as of v8/v8@7a159da Refs: nodejs/node-v8#34 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> PR-URL: nodejs#18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs#18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Earlier we used to produce code cache along with compile. Now V8 has added an API to request code cache. Support for producing code cache along with compile will be removed soon. PR-URL: nodejs#18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Original commit message: [inspector] Make test byte order independent Change-Id: If0fdc76170ad29b4d3dadddbb32bc87c307c04af Reviewed-on: https://chromium-review.googlesource.com/881883 Reviewed-by: Aleksey Kozyatinskiy <[email protected]> Commit-Queue: Eugene Ostroukhov <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#50817} Refs: v8/v8@04a06c9 PR-URL: nodejs#18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Original commit message: [compiler] Fix typing of NumberToString operator. It must be monotone. [email protected] Bug: v8:7354 Change-Id: I08dcd3333518029eef08c074c2b91b5c20ad699e Reviewed-on: https://chromium-review.googlesource.com/880982 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Georg Neis <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#50801} Refs: v8/v8@8bfbe25 PR-URL: nodejs#18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: nodejs#18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Original commit message: Use wider types for max_old_space_size and co. Make --max_old_space_size and friends work with values >= 2**31. Such values did not work reliably (or sometimes not all) due to signed integer overflow in size computations, which is UB. Fixesnodejs#18786. Bug: chromium:814138 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ibe23cef2417fd5b4a727022b8b0d4b50f1417182 Reviewed-on: https://chromium-review.googlesource.com/927063 Commit-Queue: Ben Noordhuis <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#51433} Refs: v8/v8@46c4979 PR-URL: nodejs#18453 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
13 participants
ETA: Mar 6th, 2018
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
V8