test: fix test-tty-get-color-depth#18478
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
If getTTYfd returns 0, and stdin is not writable (like on Windows), trying to create WriteStream will fail. This commit fixes that by skipping fd 0.
ContributorAuthor
bzoz commented Jan 31, 2018
cjihrig approved these changes Jan 31, 2018
BridgeAR approved these changes Jan 31, 2018
BridgeAR added fast-track 
jasnell approved these changes Jan 31, 2018
Member
BridgeAR commented Feb 1, 2018
Landed in ef28619 |
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 1, 2018
If getTTYfd returns 0, and stdin is not writable (like on Windows), trying to create WriteStream will fail. This commit fixes that by skipping fd 0. PR-URL: nodejs#18478 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax removed the author ready 
Contributor
MylesBorins commented Feb 20, 2018
test that this modifies does not exist on v9.x, setting as don't land |
ContributorAuthor
bzoz commented Mar 28, 2018
@MylesBorins the affected test was back ported in #19230, so this PR should be also backported now |
targos pushed a commit that referenced this pull request Mar 30, 2018
If getTTYfd returns 0, and stdin is not writable (like on Windows), trying to create WriteStream will fail. This commit fixes that by skipping fd 0. PR-URL: #18478 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
If getTTYfd returns 0, and stdin is not writable (like on Windows), trying to create WriteStream will fail. This commit fixes that by skipping fd 0. PR-URL: nodejs#18478 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
getTTYfd()returns 0, and stdin is not writable (like on Windows), trying to createWriteStreamwill fail. This commit fixes that by skipping fd 0.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test