assert: fix throws trace#18595
Closed
assert: fix throws trace #18595
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it.
nodejs-github-bot added the assert 
MemberAuthor
BridgeAR commented Feb 6, 2018
jasnell approved these changes Feb 6, 2018
apapirovski approved these changes Feb 6, 2018
lib/assert.js Outdated
| returnmsg; | ||
| return`${key}: expected ${inspect(expected[key])}, `+ | ||
| `not ${inspect(actual[key])}`; | ||
| functioncompareKey(actual,expected,key,msg){ |
Contributor
There was a problem hiding this comment.
Nit: could we give this function a slightly more descriptive name since it only works for throws? Like compareExceptionKey or something?
BridgeAR added the author ready apapirovski approved these changes Feb 6, 2018
MemberAuthor
BridgeAR commented Feb 6, 2018
I only changed the function name since the CI and it was green before, so I do not rerun it now. |
apapirovski pushed a commit to apapirovski/node that referenced this pull request Feb 9, 2018
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. PR-URL: nodejs#18595 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Contributor
apapirovski commented Feb 9, 2018
Landed in cccddc5 |
Contributor
MylesBorins commented Feb 21, 2018
Should this be backported to |
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 8, 2018
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. PR-URL: nodejs#18595 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
4 tasks
MemberAuthor
BridgeAR commented Mar 8, 2018
Backport opened in #19230 |
MylesBorins pushed a commit that referenced this pull request Mar 15, 2018
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. Backport-PR-URL: #19230 PR-URL: #18595 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. Backport-PR-URL: #19230 PR-URL: #18595 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. PR-URL: nodejs#18595 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Contributor
MylesBorins commented Jul 31, 2018
Requested backport to 8.x in #19230 |
BridgeAR added a commit to BridgeAR/node that referenced this pull request Oct 2, 2018
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. PR-URL: nodejs#18595 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 31, 2018
The current stack trace thrown in case `assert.throws(fn, object)` is used did not filter the stack trace. This fixes it. Backport-PR-URL: #23223 PR-URL: #18595 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current stack trace thrown in case
assert.throws(fn, object)is used did not filter the stack trace. This fixes it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
assert