Revert "src: add getopt option parser"#1862
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Fishrock123 commented Jun 1, 2015
@evanlucas want to try fixing before reverting? |
ContributorAuthor
evanlucas commented Jun 1, 2015
Working on it now. Just wanted to go ahead and open the revert PR. |
Contributor
Fishrock123 commented Jun 1, 2015
ContributorAuthor
evanlucas commented Jun 1, 2015
@Fishrock123#1864 includes a fix. |
mscdex added the c++ 
Member
bnoordhuis commented Jun 1, 2015
Rubber-stamp LGTM. |
This reverts commit c0e7bf2. There are a few edge cases that can cause a crash and need to be properly handled. PR-URL: nodejs#1862 Reviewed-By: Ben Noordhuis <[email protected]>
ContributorAuthor
evanlucas commented Jun 1, 2015
Landed in 5b6f575. Thanks |
andrewdeandrade pushed a commit to andrewdeandrade/node that referenced this pull request Jun 3, 2015
This reverts commit c0e7bf2. There are a few edge cases that can cause a crash and need to be properly handled. PR-URL: nodejs/node#1862 Reviewed-By: Ben Noordhuis <[email protected]>
Contributor
Fishrock123 commented Aug 12, 2015
@evanlucas do you think you'll have time to pick this back up at some point? |
ContributorAuthor
evanlucas commented Aug 12, 2015
had actually just started working on it again yesterday :] |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c0e7bf2.
There are a few edge cases that can cause a crash
and need to be properly handled.
Example:
node -ieApologies for not catching this before merging.