repl: better handling of recoverable errors#18915
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax approved these changes Feb 21, 2018
Contributor
Leko commented Feb 24, 2018
daynin approved these changes Feb 24, 2018
Contributor
Leko commented Feb 25, 2018
CI failed but I think those errors are not related to this PR. https://ci.nodejs.org/job/node-test-commit-linux/nodes=debian8-64/16655/console https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos7-64/16655/console |
Contributor
Leko commented Feb 26, 2018
jasnell approved these changes Feb 26, 2018
Is this the right place to add other syntax errors that the repl doesn't handle correctly? I can't find an issue for it. |
3 tasks
BridgeAR approved these changes Mar 2, 2018
Member
BridgeAR left a comment
BridgeAR left a comment There was a problem hiding this comment.
LGTM. Just a nit and a question.
lib/repl.js Outdated
Member
There was a problem hiding this comment.
Nit: please remove the else. This is a style that is normally not used here.
ContributorAuthor
There was a problem hiding this comment.
rebasing and amending to same commit
test/parallel/test-repl.js Outdated
Member
There was a problem hiding this comment.
I guess recovering from e.g.
'`abc ${test'is not possible anymore?
ContributorAuthor
There was a problem hiding this comment.
Yes, only some forms are not possible. For instance, below one is possible.
`abc ${test}`Its mostly consistent with chrome console behaviour except for couple of cases.
- we handle 'missing ) after argument list' error better than chrome console.
- we allow repl commands in multiline mode which should otherwise be treated as properties/functions.
princejwesley@c1796b8 (wip)
> (function(){... x ={help: () => 'help received' }; ... return x ... .help (); <-- no repl command parsing in multiline mode .break Sometimes you get stuck, this gets you out .clear Alias for .break .editor Enter editor mode .exit Exit the repl .help Print this help message .load Load JS from a file into the REPL session .save Save all evaluated commands in this REPL session to a file ... (I'll give PR over the weekend)
Member
BridgeAR commented Mar 2, 2018
@0joshuaolson1 please open a new issue in case you think the repl should recover from errors that you ran into. |
BridgeAR added the author ready 
Below syntax errors are handled without force .break/clear - Unexpected Token (prefix errors) - missing ) after argument list In the multiline expression, recoverable errors are truly recoverable, otherwise syntax error will be thrown.
Member
BridgeAR commented Mar 6, 2018
Member
Landed in ebfa8b1 🎉 |
BridgeAR pushed a commit that referenced this pull request Mar 11, 2018
Below syntax errors are handled without force .break/clear - Unexpected Token (prefix errors) - missing ) after argument list In the multiline expression, recoverable errors are truly recoverable, otherwise syntax error will be thrown. PR-URL: #18915 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Mar 17, 2018
Below syntax errors are handled without force .break/clear - Unexpected Token (prefix errors) - missing ) after argument list In the multiline expression, recoverable errors are truly recoverable, otherwise syntax error will be thrown. PR-URL: #18915 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Below syntax errors are handled without force .break/clear - Unexpected Token (prefix errors) - missing ) after argument list In the multiline expression, recoverable errors are truly recoverable, otherwise syntax error will be thrown. PR-URL: #18915 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Below syntax errors are handled without force .break/clear - Unexpected Token (prefix errors) - missing ) after argument list In the multiline expression, recoverable errors are truly recoverable, otherwise syntax error will be thrown. PR-URL: nodejs#18915 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
Below syntax errors are handled without force .break/clear - Unexpected Token (prefix errors) - missing ) after argument list In the multiline expression, recoverable errors are truly recoverable, otherwise syntax error will be thrown. PR-URL: nodejs#18915 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
Below syntax errors are handled without force .break/clear - Unexpected Token (prefix errors) - missing ) after argument list In the multiline expression, recoverable errors are truly recoverable, otherwise syntax error will be thrown. Backport-PR-URL: #22380 PR-URL: #18915 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better handling of recoverable errors in REPL module
Below syntax errors are handled without force .break/clear
In the multiline expression, recoverable errors are truly
recoverable, otherwise syntax error will be thrown.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
repl