doc: make suggestion more direct in stream.md#19124
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added the stream 
Trott commented Mar 4, 2018
I think it would be better to explain why, because |
Trott commented Mar 4, 2018
Suggested text, anyone? |
gibfahn commented Mar 5, 2018
Yeah that's why it was a non-blocking suggestion (from me at least) 😁 . |
The text seems to have been added by @jasnell in #6947. Quickly browsing that PR's reviews, it seems @chrisdickinson may have implicitly suggested its inclusion, although no reasoning was given behind the sentiment there either. I think either the comment should be removed entirely or perhaps a reduced version of the comment should be used instead, one that promotes the use of |
Trott commented Mar 7, 2018
Landed in cb5f9a6. Will follow up on @mscdex's suggestion in a subsequent pull request. |
PR-URL: #19124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #19124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: #19124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs#19124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
PR-URL: nodejs#19124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Backport-PR-URL: #22380 PR-URL: #19124 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
7 participants
Checklist
Affected core subsystem(s)
doc