test: minor refactoring#19130
Closed
test: minor refactoring #19130
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
change to arrow functions
cjihrig approved these changes Mar 4, 2018
gireeshpunathil approved these changes Mar 5, 2018
gibfahn approved these changes Mar 5, 2018
Member
Looks good, but needs a manual test as CI doesn't test |
Member
gibfahn commented Mar 5, 2018
tniessen approved these changes Mar 5, 2018
ContributorAuthor
@gibfahn Thanks for your comment. I tested it with the following command, and the result looks ok. $ python tools/test.py -J --mode=release test/internet/test-http-https-default-ports [00:01|% 100|+ 1|- 0]: DoneDo you have other suggestion of the manual test? Thank you. |
jasnell approved these changes Mar 5, 2018
Member
gibfahn commented Mar 5, 2018
Nope that's perfect, just wanted to make sure someone had tried it. Thanks! |
maclover7 approved these changes Mar 6, 2018
BridgeAR approved these changes Mar 6, 2018
BridgeAR added fast-track ContributorAuthor
ken23421 commented Mar 8, 2018
Thanks @gibfahn |
Member
gibfahn commented Mar 9, 2018
Landing... |
Member
gibfahn commented Mar 9, 2018
Landed in 06e09b6 |
gibfahn pushed a commit that referenced this pull request Mar 9, 2018
Use arrow functions. PR-URL: #19130 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
gibfahn commented Mar 9, 2018
@ken23421 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
ContributorAuthor
ken23421 commented Mar 10, 2018
@gibfahn Thanks a lot for your help :) |
targos pushed a commit that referenced this pull request Mar 17, 2018
Use arrow functions. PR-URL: #19130 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Use arrow functions. PR-URL: #19130 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Use arrow functions. PR-URL: nodejs#19130 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
Use arrow functions. PR-URL: nodejs#19130 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
Use arrow functions. Backport-PR-URL: #22380 PR-URL: #19130 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change to arrow functions
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test