src: use smart pointer in AsyncWrap::WeakCallback#19168
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
ContributorAuthor
danbev commented Mar 6, 2018
addaleax approved these changes Mar 6, 2018
| Environment* env = Environment::GetCurrent(info.GetIsolate()); | ||
| DestroyParam* p = info.GetParameter(); | ||
| std::unique_ptr<DestroyParam> p{info.GetParameter()}; |
Member
There was a problem hiding this comment.
Nit: Can you add a comment here that says that assigning the pointer will destroy the object at the end of the function?
I like smart pointers, but I think this is one of the cases where the ownership flow becomes a bit less obvious. I find it hard to put a finger on what exactly it is, but I think it’s mostly that we have a new call that creates the object and works with it as a raw pointer on the one end, and use a smart pointer on the other side (i.e. there’s no matching delete call)…
ContributorAuthor
There was a problem hiding this comment.
No problems, I'll add a comment. Thanks
cjihrig approved these changes Mar 6, 2018
jasnell approved these changes Mar 6, 2018
Member
BridgeAR commented Mar 6, 2018
BridgeAR added author ready 
joyeecheung approved these changes Mar 7, 2018
ContributorAuthor
danbev commented Mar 8, 2018
node-test-commit failure looks unrelatednot ok 1943 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary --- duration_ms: 26.585 severity: crashed stack: |- oh no! exit code: CRASHED (Signal: 9) ...not ok 1944 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex --- duration_ms: 29.225 severity: crashed stack: |- oh no! exit code: CRASHED (Signal: 9) ...node-test-commit-aix failure looks unrelatednot ok 1244 parallel/test-performance --- duration_ms: 2.838 severity: fail stack: |- assert.js:249 throw err; ^ AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value: assert(Math.abs(delta) < 1000) at checkNodeTiming (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-performance.js:118:7) at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-performance.js:125:1) at Module._compile (module.js:670:30) at Object.Module._extensions..js (module.js:681:10) at Module.load (module.js:581:32) at tryModuleLoad (module.js:521:12) at Function.Module._load (module.js:513:3) at Function.Module.runMain (module.js:711:10) at startup (bootstrap_node.js:223:16) at bootstrapNodeJSCore (bootstrap_node.js:562:3) |
ContributorAuthor
danbev commented Mar 8, 2018
Landed in 1e3dd8b. |
danbev added a commit that referenced this pull request Mar 8, 2018
PR-URL: #19168 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Mar 17, 2018
PR-URL: #19168 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
PR-URL: #19168 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#19168 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Member
jasnell commented Aug 17, 2018
Should this be backported to 8.x? If so, a separate backport PR is needed. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes