Skip to content

Conversation

@ofrobots
Copy link
Contributor

@ofrobotsofrobots commented Mar 6, 2018

Add a simple example showing how to use the inspector API to access
the CPU profiler.

Checklist

CI-light: https://ci.nodejs.org/view/Node.js/job/node-test-commit-light/362/https://ci.nodejs.org/view/Node.js/job/node-test-commit-light/365/

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol labels Mar 6, 2018
@BridgeARBridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 6, 2018
@BridgeAR
Copy link
Member

Seems like there is a linter issue @ofrobots

@ofrobotsofrobotsforce-pushed the inspector-profile-example branch from c7a832e to 7a77c16CompareMarch 6, 2018 17:53
@ofrobots
Copy link
ContributorAuthor

Fixed.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 6, 2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: meansurement -> measurement

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from debugger -> Apart from the debugger perhaps?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Fixed.

Add a simple example showing how to use the inspector API to access the CPU profiler. PR-URL: nodejs#19172 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
@ofrobotsofrobotsforce-pushed the inspector-profile-example branch from d318483 to fbf7ff9CompareMarch 8, 2018 01:03
@ofrobotsofrobots merged commit fbf7ff9 into nodejs:masterMar 8, 2018
@ofrobots
Copy link
ContributorAuthor

Landed as fbf7ff9.

@ofrobotsofrobots deleted the inspector-profile-example branch March 8, 2018 01:10
targos pushed a commit that referenced this pull request Mar 17, 2018
Add a simple example showing how to use the inspector API to access the CPU profiler. PR-URL: #19172 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
@targostargos mentioned this pull request Mar 18, 2018
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Add a simple example showing how to use the inspector API to access the CPU profiler. PR-URL: #19172 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Add a simple example showing how to use the inspector API to access the CPU profiler. PR-URL: nodejs#19172 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
Add a simple example showing how to use the inspector API to access the CPU profiler. PR-URL: nodejs#19172 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
Add a simple example showing how to use the inspector API to access the CPU profiler. Backport-PR-URL: #22380 PR-URL: #19172 Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Sep 6, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.inspectorIssues and PRs related to the V8 inspector protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@ofrobots@BridgeAR@eugeneo@Trott@lpinca@cjihrig@XadillaX@vsemozhetbyt@nodejs-github-bot