src: add convenience ctor for async trigger id scope#19204
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added c++ 
MemberAuthor
addaleax commented Mar 7, 2018
joyeecheung approved these changes Mar 7, 2018
addaleax added the author ready 
jasnell approved these changes Mar 7, 2018
danbev approved these changes Mar 8, 2018
MemberAuthor
addaleax commented Mar 11, 2018
Landed in d3f174f |
addaleax added a commit that referenced this pull request Mar 11, 2018
PR-URL: #19204 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
targos pushed a commit that referenced this pull request Mar 17, 2018
PR-URL: #19204 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
PR-URL: #19204 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#19204 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
addaleax added a commit to addaleax/node that referenced this pull request Jun 30, 2018
This backport differs from the original only in the omission of a change to `stream_base-inl.h` which would have generated conflicts. PR-URL: nodejs#19204
4 tasks
MylesBorins pushed a commit that referenced this pull request Jul 13, 2018
This backport differs from the original only in the omission of a change to `stream_base-inl.h` which would have generated conflicts. Backport-PR-URL: #21600 PR-URL: #19204 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
This backport differs from the original only in the omission of a change to `stream_base-inl.h` which would have generated conflicts. Backport-PR-URL: #21600 PR-URL: #19204 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting this out from #18936
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes