Skip to content

tools: make test-npm work without global npm#1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fishrock123 merged 1 commit into from
Jun 17, 2015
Merged

tools: make test-npm work without global npm #1926

Fishrock123 merged 1 commit into from
Jun 17, 2015

Conversation

@Fishrock123
Copy link
Contributor

@Fishrock123Fishrock123 commented Jun 9, 2015

Calling the tests independently removes the dependancy on npm internally trying to call npm run-script for test-all.

R= @othiym23 / @mhdawson?

@Fishrock123Fishrock123 added test Issues and PRs related to the tests. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jun 9, 2015
@Fishrock123Fishrock123 mentioned this pull request Jun 12, 2015
Closed
@Fishrock123
Copy link
ContributorAuthor

Fishrock123 commented Jun 15, 2015

cc @nodejs/build

@rvagg
Copy link
Member

rvagg commented Jun 16, 2015

lgtm if you're confirming it works

@Fishrock123
Copy link
ContributorAuthor

Fishrock123 commented Jun 16, 2015

It does definitely work, and also without a global npm.

@mhdawson
Copy link
Member

mhdawson commented Jun 16, 2015

lgtm as it mirrors https://github.com/mhdawson/node/commit/859e4eec65544be62d2dad1cbea80bf097e48756

@Fishrock123
tools: make test-npm work without global npm
91dfb5e
Futher discussion at nodejs/node-v0.x-archive#25294 PR-URL: nodejs#1926 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@Fishrock123Fishrock123force-pushed the allow-test-npm-without-installed-npm branch from ef5c9c3 to 91dfb5eCompareJune 17, 2015 16:28
@Fishrock123Fishrock123 merged commit 91dfb5e into nodejs:masterJun 17, 2015
@Fishrock123
Copy link
ContributorAuthor

Fishrock123 commented Jun 17, 2015

Thanks!

@rvaggrvagg mentioned this pull request Jun 18, 2015
Closed
@mhdawsonmhdawson mentioned this pull request Apr 15, 2016
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

npmIssues and PRs related to the npm client dependency or the npm registry.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fishrock123@rvagg@mhdawson