test: fix test-cluster-send-handle-large-payload#19311
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
test-cluster-send-handle-large-payload is susceptible to failure if it is competing for resources. Move to `sequential` directory so it is not competing with other tests. Fixes: nodejs#14844
MemberAuthor
Trott commented Mar 13, 2018
danbev approved these changes Mar 13, 2018
Member
santigimeno commented Mar 13, 2018
This will make the test less flaky but the |
MemberAuthor
Trott commented Mar 13, 2018
@santigimeno Stress tests on FreeBSD show that there the test does not fail except when run in parallel (that is, with |
Trott added the author ready Member
santigimeno commented Mar 13, 2018
Yeah, I don't disagree. I meant that the underlying issue will still be there though less visible. |
MemberAuthor
Trott commented Mar 13, 2018
Oh, I see. Yes. If we can find a way to trigger the issue reliably without consuming a ton of resources, we could create a |
MemberAuthor
Trott commented Mar 15, 2018
Landed in 5e23b65 |
Trott added a commit to Trott/io.js that referenced this pull request Mar 15, 2018
test-cluster-send-handle-large-payload is susceptible to failure if it is competing for resources. Move to `sequential` directory so it is not competing with other tests. Fixes: nodejs#14844 PR-URL: nodejs#19311 Reviewed-By: Daniel Bevenius <[email protected]>
targos pushed a commit that referenced this pull request Mar 17, 2018
test-cluster-send-handle-large-payload is susceptible to failure if it is competing for resources. Move to `sequential` directory so it is not competing with other tests. Fixes: #14844 PR-URL: #19311 Reviewed-By: Daniel Bevenius <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
test-cluster-send-handle-large-payload is susceptible to failure if it is competing for resources. Move to `sequential` directory so it is not competing with other tests. Fixes: #14844 PR-URL: #19311 Reviewed-By: Daniel Bevenius <[email protected]>
4 tasks
MylesBorins pushed a commit that referenced this pull request Jul 31, 2018
test-cluster-send-handle-large-payload is susceptible to failure if it is competing for resources. Move to `sequential` directory so it is not competing with other tests. Fixes: #14844 PR-URL: #19311 Reviewed-By: Daniel Bevenius <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
test-cluster-send-handle-large-payload is susceptible to failure if it is competing for resources. Move to `sequential` directory so it is not competing with other tests. Fixes: #14844 PR-URL: #19311 Reviewed-By: Daniel Bevenius <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-cluster-send-handle-large-payload is susceptible to failure if it
is competing for resources. Move to
sequentialdirectory so it is notcompeting with other tests.
Fixes: #14844
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes