Skip to content

doc: fix minor issues in async_hooks.md#19313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

doc: fix minor issues in async_hooks.md #19313

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@TrottTrott commented Mar 13, 2018

  • easily -> easy
  • was -> is
  • add a missing comma
Checklist

@Trott
doc: fix minor issues in async_hooks.md
e216256
* easily -> easy * was -> is * add a missing comma
@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Mar 13, 2018
@Trott
Copy link
MemberAuthor

Trott commented Mar 13, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/253/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 13, 2018
@Trott
Copy link
MemberAuthor

Trott commented Mar 15, 2018

Landed in e5e0f9f

@TrottTrott closed this Mar 15, 2018
Trott added a commit to Trott/io.js that referenced this pull request Mar 15, 2018
@Trott
doc: fix minor issues in async_hooks.md
e5e0f9f
* easily -> easy * was -> is * add a missing comma PR-URL: nodejs#19313 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Mar 17, 2018
@Trott@targos
doc: fix minor issues in async_hooks.md
fd47342
* easily -> easy * was -> is * add a missing comma PR-URL: #19313 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@targostargos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
@Trott@MylesBorins
doc: fix minor issues in async_hooks.md
5a56327
* easily -> easy * was -> is * add a missing comma PR-URL: #19313 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@Trott@BethGriggs
doc: fix minor issues in async_hooks.md
9446bb6
* easily -> easy * was -> is * add a missing comma PR-URL: #19313 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
@TrottTrott deleted the quick-fixes branch January 13, 2022 22:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

+1 more reviewer

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@lpinca@cjihrig@vsemozhetbyt@nodejs-github-bot