doc: improve best practices in onboarding-extras#19315
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
Trott commented Mar 13, 2018
danbev approved these changes Mar 13, 2018
targos approved these changes Mar 13, 2018
cjihrig approved these changes Mar 13, 2018
Trott added the author ready 
lpinca approved these changes Mar 13, 2018
richardlau approved these changes Mar 14, 2018
Member
richardlau left a comment
richardlau left a comment There was a problem hiding this comment.
LGTM
When making PRs, spend time writing a thorough description.
🤔 😆
Trott added a commit to Trott/io.js that referenced this pull request Mar 15, 2018
PR-URL: nodejs#19315 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
MemberAuthor
Trott commented Mar 15, 2018
Landed in 536190f |
targos pushed a commit that referenced this pull request Mar 17, 2018
PR-URL: #19315 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
PR-URL: #19315 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
PR-URL: #19315 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist