Skip to content

Conversation

@hiroppy
Copy link
Member

Modify Yuta Hiroto's account information.

Checklist

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 14, 2018
@hiroppy
Copy link
MemberAuthor

@TrottTrott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 14, 2018
Copy link
Contributor

@MylesBorinsMylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiroppy
Copy link
MemberAuthor

This pr does not need to wait 24h so I wold like to merge:) Thank you for reviewing.

hiroppy added a commit that referenced this pull request Mar 14, 2018
PR-URL: #19338 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@hiroppy
Copy link
MemberAuthor

Landed in 0a56a1b.

@hiroppyhiroppy closed this Mar 14, 2018
@hiroppyhiroppy deleted the feature/modify-my-account branch March 14, 2018 11:55
targos pushed a commit that referenced this pull request Mar 17, 2018
PR-URL: #19338 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@targostargos mentioned this pull request Mar 18, 2018
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
PR-URL: #19338 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@tniessentniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#19338 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
PR-URL: #19338 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@hiroppy@danbev@jasnell@MylesBorins@yosuke-furukawa@Trott@gireeshpunathil@BridgeAR@tniessen@BethGriggs@nodejs-github-bot