http2: destroy() stream, upon errnoException#19389
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
First steps towards nodejs#19060
nodejs-github-bot added dont-land-on-v4.x http2 
jasnell approved these changes Mar 16, 2018
addaleax added the author ready 
Member
addaleax commented Mar 19, 2018
Member
jasnell commented Mar 20, 2018
The failures in CI are related. |
Author
SirR4T commented Mar 20, 2018
Member
addaleax commented Mar 23, 2018
I can’t see anything in the CI failures that strikes out as something related. |
4 tasks
Member
addaleax commented Mar 23, 2018
Landed in 84afd6e 🎉 |
addaleax removed the author ready addaleax pushed a commit that referenced this pull request Mar 23, 2018
First steps towards #19060 PR-URL: #19389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Apr 2, 2018
First steps towards #19060 PR-URL: #19389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
First steps towards nodejs#19060 PR-URL: nodejs#19389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
First steps towards #19060 Backport-PR-URL: #20456 PR-URL: #19389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request May 15, 2018
First steps towards #19060 Backport-PR-URL: #20456 PR-URL: #19389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
First steps towards #19060 Backport-PR-URL: #20456 PR-URL: #19389 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First steps towards #19060
Attempting to move
lib/netandlib/http2/coretowards similar API, for all work of reading and writing from underlying stream.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes