n-api: separate out async_hooks test#19392
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Place the test_make_callback async_hooks-related test into its own file.
nodejs-github-bot added dont-land-on-v4.x node-api 
jasnell approved these changes Mar 16, 2018
ContributorAuthor
gabrielschulhof commented Mar 17, 2018
Both these failures are on test/parallel. I don't believe they are related. |
ContributorAuthor
gabrielschulhof commented Mar 19, 2018
Landed in f24d0ec. |
gabrielschulhof pushed a commit that referenced this pull request Mar 19, 2018
Place the test_make_callback async_hooks-related test into its own file. PR-URL: #19392 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Place the test_make_callback async_hooks-related test into its own file. PR-URL: #19392 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Place the test_make_callback async_hooks-related test into its own file. PR-URL: #19392 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 12, 2018
Place the test_make_callback async_hooks-related test into its own file. PR-URL: nodejs#19392 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 1, 2018
Place the test_make_callback async_hooks-related test into its own file. Backport-PR-URL: #19265 PR-URL: #19392 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Place the test_make_callback async_hooks-related test into its own file.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes