http2: general code cleanups#19400
Closed
http2: general code cleanups #19400
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Most of the inlines were leftovers from a much older design iteration and are largely pointless or counter productive.
Use of a MaybeStackBuffer was just silly. Fix a long standing todo Reduce code duplication a bit.
nodejs-github-bot added c++ 
addaleax approved these changes Mar 16, 2018
src/node_http2.cc Outdated
| }; | ||
| session->MakeCallback(env->error_string(), arraysize(argv), argv); | ||
| Local<Value> argv = Integer::New(isolate, lib_error_code); | ||
| session->MakeCallback(env->error_string(), 1, &argv); |
Member
There was a problem hiding this comment.
You may want to call this arg, since it’s not really a vector any longer :)
(ditto below)
MemberAuthor
jasnell commented Mar 16, 2018
mcollina approved these changes Mar 17, 2018
| // frame. This can be used, for instance, to create the Base64-encoded | ||
| // content of an Http2-Settings header field. | ||
| inlineLocal<Value> Http2Session::Http2Settings::Pack(){ | ||
| Local<Value> Http2Session::Http2Settings::Pack(){ |
Member
There was a problem hiding this comment.
is it ok to remove this inline directive here and in the other functions? Wouldn't this impact perf somehow?
Member
There was a problem hiding this comment.
@mcollina It’s not only okay, it’s more or less the correct thing to do.
This has a pretty good explanation. tl;dr: Compilers are generally better than humans at judging what functions to inline or not, and will gladly ignore this advice. However, inline does affect the linkage properties of a function, and so its primary use should be to mark functions that are defined in header files (outside of a class definition).
I just tested it with gcc, and the compiler output is the same before and after this commit, byte-for-byte.
jasnell added a commit that referenced this pull request Mar 18, 2018
Most of the inlines were leftovers from a much older design iteration and are largely pointless or counter productive. PR-URL: #19400 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
jasnell added a commit that referenced this pull request Mar 18, 2018
Use of a MaybeStackBuffer was just silly. Fix a long standing todo Reduce code duplication a bit. PR-URL: #19400 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
jasnell added a commit that referenced this pull request Mar 18, 2018
PR-URL: #19400 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MemberAuthor
jasnell commented Mar 18, 2018
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Most of the inlines were leftovers from a much older design iteration and are largely pointless or counter productive. PR-URL: #19400 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Use of a MaybeStackBuffer was just silly. Fix a long standing todo Reduce code duplication a bit. PR-URL: #19400 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
PR-URL: #19400 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Most of the inlines were leftovers from a much older design iteration and are largely pointless or counter productive. PR-URL: #19400 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
Use of a MaybeStackBuffer was just silly. Fix a long standing todo Reduce code duplication a bit. PR-URL: #19400 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
PR-URL: #19400 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
Member
@jasnell could you backport this to |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @addaleax@mcollina
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes