test: refactor test-fs-readfile-tostring-fail#19404
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The test uses both `assert()` and `assert.ok()`. Use just `assert.ok()`. Remove a comment that does not appear to match the code and does not seem to explain much beyond the bare code itself.
MemberAuthor
Trott commented Mar 17, 2018
richardlau approved these changes Mar 17, 2018
lpinca approved these changes Mar 17, 2018
MemberAuthor
Trott commented Mar 17, 2018
Lone CI failure is a build failure unrelated to this change. Re-run: https://ci.nodejs.org/job/node-test-commit-plinux/16116/ |
Trott added the author ready MemberAuthor
Trott commented Mar 17, 2018
(Re-run of lone CI build failure is green.) |
Leko approved these changes Mar 17, 2018
jasnell approved these changes Mar 17, 2018
cjihrig approved these changes Mar 19, 2018
Trott added a commit to Trott/io.js that referenced this pull request Mar 20, 2018
The test uses both `assert()` and `assert.ok()`. Use just `assert.ok()`. Remove a comment that does not appear to match the code and does not seem to explain much beyond the bare code itself. PR-URL: nodejs#19404 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
Trott commented Mar 20, 2018
Landed in 1203b13 |
MylesBorins pushed a commit that referenced this pull request Mar 22, 2018
The test uses both `assert()` and `assert.ok()`. Use just `assert.ok()`. Remove a comment that does not appear to match the code and does not seem to explain much beyond the bare code itself. PR-URL: #19404 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
tniessen removed the author ready BethGriggs pushed a commit that referenced this pull request Oct 26, 2018
The test uses both `assert()` and `assert.ok()`. Use just `assert.ok()`. Remove a comment that does not appear to match the code and does not seem to explain much beyond the bare code itself. PR-URL: #19404 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test uses both
assert()andassert.ok(). Use justassert.ok().Remove a comment that does not appear to match the code and does not
seem to explain much beyond the bare code itself.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes