Skip to content

Conversation

@targos
Copy link
Member

@targostargos commented Mar 17, 2018

This also fixes the error thrown (was 'The "%s" argument is out of range').

Original PR: #18848

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

PR-URL: nodejs#18848 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 17, 2018
@targostargos changed the base branch from master to v9.x-stagingMarch 17, 2018 13:12
@targostargos added http2 Issues or PRs related to the http2 subsystem. v9.x and removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 17, 2018
@MylesBorins
Copy link
Contributor

landed in 6908b8fd62

@targostargos deleted the fix-http2-error-9.x branch October 17, 2020 12:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@targos@MylesBorins@Leko@nodejs-github-bot@trivikr