tools: fix nits in tools/doc/preprocess.js#19473
Closed
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesES6 nits:
vars withlets..forEach()argument.RegExp nits:
[A-Za-z0-9-_]into[\w-].includeExprRegExp: there is no need to group in its case +includeExpris used only in.match()call that does not return capturing..match()with.test()in a boolean context.Logic nits:
.match()withgflag can only returnnullor non-empty array (it cannot return an array with0length) +incCountmay be changed only after this check.I've built the docs on Windows (using #19330) before and after these changes and both doc sets are identical +
test/doctool/test-make-doc.jsis OK.