[v9.x backport] http2: fixes error handling#19478
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added dont-land-on-v4.x http2 MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/13768/ edit by @MylesBorins: looks like we had a race condition. Kicked off CI and updated link |
Contributor
MylesBorins commented Mar 20, 2018
@mcollina seems like quite a few failures on this one. Want to try rebasing and running CI again? |
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: nodejs#14991 PR-URL: nodejs#19232 Reviewed-By: James M Snell <[email protected]>
mcollinaforce-pushed the backport-19232-to-v9.x-ter branch from 2a0aa23 to f36e5b4CompareMemberAuthor
mcollina commented Mar 21, 2018
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
There should be no default error handling when using Http2Stream. All errors will end up in `'streamError'` on the server anyway, but they are emitted on `'stream'` as well, otherwise some error conditions are impossible to debug. See: #14991 Backport-PR-URL: #19478 PR-URL: #19232 Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Mar 21, 2018
landed in 3914e97 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There should be no default error handling when using Http2Stream.
All errors will end up in
'streamError'on the server anyway,but they are emitted on
'stream'as well, otherwise some errorconditions are impossible to debug.
See: #14991
PR-URL: #19232
Reviewed-By: James M Snell [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes