[v9.x] doc: fix deprecation removed by mistake#19482
Closed
+13 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In nodejs@bae5de1, a deprecation (DEP0089) was added to the docs and another one (DEP0098) was removed by mistake. This commit restores it.
targos added doc 
targos changed the title 
MemberAuthor
targos commented Mar 20, 2018
Member
BridgeAR commented Mar 20, 2018
@targos thanks for fixing this. Seems like I removed that in the backport by mistake. |
BridgeAR approved these changes Mar 20, 2018
cjihrig approved these changes Mar 20, 2018
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
In bae5de1, a deprecation (DEP0089) was added to the docs and another one (DEP0098) was removed by mistake. This commit restores it. PR-URL: #19482 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Contributor
MylesBorins commented Mar 20, 2018
landed in a4c28d7 |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In bae5de1,
a deprecation (DEP0089) was added to the docs and another one (DEP0098)
was removed by mistake. This commit restores it.
Fixes#19428 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes