doc: wrap buffer.md at 80 characters#19546
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added buffer 
Trott commented Mar 23, 2018
Trott added the author ready 
vsemozhetbyt added the fast-track 
apapirovski commented Mar 23, 2018
ping @mcollina given the objections last time this came up. |
mcollina removed the fast-track 
mcollina commented Mar 23, 2018
I'm still -1 for the time being on this. Happy for this go to a TSC vote if you feel strongly about it, this has been discussed extensively already and not linting this file was the middle ground that was reached. See the long discussion in #18726. Thanks @apapirovski for the ping. |
Trott commented Mar 23, 2018
@mcollina Your opposition is based on the fact that the whitespace changes will complicate backporting? Or are there other concerns too? |
mcollina commented Mar 23, 2018
I’m generically -1 on massive linting changes if I get the chance to review them. Regarding this specifically, yes it is a backport problem. |
Trott commented Mar 23, 2018
If I open backport PRs right now for 9.x, 8.x, and 6.x, would that be enough to remove your objection? Or is the churn here still just too much? |
mcollina commented Mar 23, 2018
IMHO it is too much churn. |
Trott removed the author ready 
BridgeAR commented Mar 24, 2018
mcollina commented Mar 24, 2018
As I said, I should have brought the matter to the TSC back then. Anyway, feel free to land. |
Trott commented Mar 24, 2018
There's changes in here that break links. Still need to address those. So please don't land. I'll add the |
doc/api/buffer.md Outdated
There was a problem hiding this comment.
@Trott I could be wrong, but I think the broken links can be fixed by moving the opening [ up to the previous line.
Trottforce-pushed the max-line branch 2 times, most recently from 66c9e5d to fa7b2c3CompareTrottforce-pushed the max-line branch 7 times, most recently from d425e0d to ec7b5a7Compare
BridgeAR dismissed mcollina’s stale reviewDismissing to indicate that it is fine to land this PR as mentioned in a former comment.
BridgeAR commented Apr 9, 2018
Ping @Trott |
Trott commented Apr 9, 2018
@BridgeAR Working through this slowly and opening other PRs when I find bigger issues that need addressing near one of these line-wraps. As I rebase, the change set gets smaller and smaller, which I think is A Good Thing. If having this open is a problem, feel free to close it. Otherwise, it's mildly convenient for me and it will land eventually, just not this week. |
Trottforce-pushed the max-line branch 4 times, most recently from 94cb561 to 18e5b0cCompareTrottforce-pushed the max-line branch 3 times, most recently from a54da8e to c6ef2a2CompareTrott commented Apr 20, 2018
Trott changed the title 
Wrap `buffer.md` at 80 characters and enforce with linter.
Trott commented Apr 20, 2018
Wrap `buffer.md` at 80 characters and enforce with linter. PR-URL: nodejs#19546 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Trott commented Apr 20, 2018
Landed in 743341d |
Wrap `buffer.md` at 80 characters and enforce with linter. PR-URL: #19546 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
13 participants
Wrap
buffer.mdat 80 characters and enforce with linter.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes