build: simplify execution of built binary#1955
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=)
There was a problem hiding this comment.
perhaps this should also go down in to test-npm.sh? / @Fishrock123
There was a problem hiding this comment.
Yes, I unrelatedly figured out that this was broken after quickly discussing it at nodeconf. I'll open a PR.
orangemocha commented Jun 12, 2015
The usage of both NODE and NODE_EXE throughout the makefile is slightly confusing.
|
jbergstroem commented Jun 13, 2015
@orangemocha I'm all for making it more readable. I'd prefer to do it in another PR so we can land this and get a linter jenkins slave up and running. |
jbergstroem commented Jun 14, 2015
Ping @nodejs/build or other collaborators. I'd like to land this so we can get the linter going. |
bnoordhuis commented Jun 14, 2015
LGTM |
jbergstroem commented Jun 14, 2015
Here's a run through the new linter project: https://jenkins-iojs.nodesource.com/job/iojs+linter/3/ |
rvagg commented Jun 15, 2015
lgtm, :makeitso: |
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=) PR-URL: #1955 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
jbergstroem commented Jun 15, 2015
Merged in 1ec53c0. Thanks for the review. Proceeding to setting the linter job up! |
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=) PR-URL: nodejs#1955 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=) PR-URL: #1955 PORT-PR-URL: #2101 PORT-FROM: 1ec53c0 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
6 participants
Since we aleady have a variable with path to the newly built binary, use that instead of prefixing path. This also allows us to pass a different path through the environment (NODE=).
R=@nodejs/build