zlib,stream: use “official” util.types typechecks#19602
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The old variants have been deprecated since b20af80. Refs: nodejs#18415
nodejs-github-bot added stream 
TimothyGu approved these changes Mar 26, 2018
starkwang approved these changes Mar 26, 2018
cjihrig approved these changes Mar 26, 2018
MemberAuthor
addaleax commented Mar 26, 2018
joyeecheung approved these changes Mar 26, 2018
lpinca approved these changes Mar 26, 2018
lpinca added the author ready 
jasnell approved these changes Mar 28, 2018
Member
trivikr commented Mar 28, 2018
Landed in e765257 |
trivikr pushed a commit that referenced this pull request Mar 28, 2018
The old variants have been deprecated since b20af80. Refs: #18415 PR-URL: #19602 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax removed the author ready 
Member
targos commented Apr 2, 2018
Depends on #18415 to land on |
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
The old variants have been deprecated since b20af80. Refs: nodejs#18415 PR-URL: nodejs#19602 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old variants have been deprecated since b20af80.
Refs: #18415
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes