Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.4k
doc: reorder authors#1966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: reorder authors #1966
Uh oh!
There was an error while loading. Please reload this page.
Conversation
rvagg commented Jun 13, 2015
I've been thinking that maybe putting them in full alphabetical order would be best, TC members included, it decreases the importance of the TC slightly which I think is appropriate for how this project actually works. Thoughts anyone? |
jbergstroem commented Jun 13, 2015
@rvagg How about chopping up similar to: Current Project Team MembersTechnical committee
Plebs
|
monsanto commented Jun 13, 2015
+1 to the PR and to alphabetical order, no opinion on separating TC from collaborators |
rvagg commented Jun 13, 2015
@jbergstroem that's compounding the problem! I'd like it if it were shown that TC members are just collaborators that get to have a meeting every week rather than some special external group. |
jbergstroem commented Jun 13, 2015
@rvagg I don't really feel that way but I have no strong opinion in the matter. Happy to reorder on top of this PR. Lets see how it goes. Edit: Sort by first- or last name? How would we handle non-latin names? |
monsanto commented Jun 13, 2015
I think: Sort by last name, non-Latin names should be placed where their transliterated name would go |
rlidwka commented Jun 13, 2015
Sorting by the last name doesn't make much sense. Imho, it's either case-insensitive sort by full name (non-Latin at the bottom), or just sort by a nickname bypassing the whole issue altogether. |
Trott commented Jun 13, 2015
+1 to sorting on GitHub handle. That avoids a host of issues. EDIT: The corner cases I'd want to avoid are:
Using GitHub nicknames avoids all this. It's also more diversity-friendly, in my opinion. |
sam-github commented Jun 13, 2015
It would help me if they were sorted by github handle, and the text after the github handle was exactly what needs to be pasted into commit messages in the |
trevnorris commented Jun 14, 2015
I'm not opposed to reordering the names, but saying it'll help find someone is not really an argument. Don't think a text editor exists today that anyone would use that doesn't have text search. And finding their information for a Reviewed-By isn't difficult either. If they can LGTM, they've committed before and it can be found in git log. In any case, I'd vote to sort by name. Handles and emails can more easily change then a person's name. |
jbergstroem commented Jun 14, 2015
Since we don't seem to have a consensus on naming I suggest I revert the ordering and we proceed with what I originally set out to do, which was helping people using reviewed-by/git logs. Thoughts? |
rvagg commented Jun 14, 2015
which is just about switching email & github handle so you can copypasta? sounds like a plan |
jbergstroem commented Jun 14, 2015
@rvagg yeah. I'll back out my ordering commit so we can get LGTM's going. Edit: Rebased. |
6593d4b to 8b1262aCompareMake the order of name, email and other additions simpler to copy paste and/or match with git commit messages. Useful when working with `Reviewed-By`.
8b1262a to 394470dComparejbergstroem commented Jun 16, 2015
Can we get a LGTM :) |
tellnes commented Jun 16, 2015
I'm not a native english speaker, but is Otherwise, LGTM. |
bnoordhuis commented Jun 16, 2015
LGTM but I second the observation about 'reorder authors'. Maybe |
jbergstroem commented Jun 16, 2015
Ok. Will modify commit message |
jbergstroem commented Jun 17, 2015
@tellnes your gitconfig seems to differ from what we have in README.md |
Make the order of name, email and other additions simpler to copy paste and/or match with git commit messages. Useful when working with `Reviewed-By`. PR-URL: #1966 Reviewed-By: Christian Tellnes <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
jbergstroem commented Jun 17, 2015
Merged in c4ec041. Closing. |
Make the order of name, email and other additions simpler to copy paste and/or match with git commit messages.
Useful when working with
Reviewed-By.