tools: dry utility function in tools/doc/json.js#19692
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vsemozhetbyt added the fast-track 
nodejs-github-bot added doc 
ContributorAuthor
vsemozhetbyt commented Mar 30, 2018
BridgeAR approved these changes Mar 30, 2018
vsemozhetbyt added the author ready 
tniessen approved these changes Mar 30, 2018
Also, move a declaration of unrelated variable closer to its only context.
ContributorAuthor
vsemozhetbyt commented Mar 30, 2018
Rebased after the #19696 CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/368/ |
ContributorAuthor
vsemozhetbyt commented Mar 30, 2018
Landed in 83d44be |
vsemozhetbyt added a commit that referenced this pull request Mar 30, 2018
Also, move a declaration of unrelated variable closer to its only context. PR-URL: #19692 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
targos pushed a commit that referenced this pull request Apr 2, 2018
Also, move a declaration of unrelated variable closer to its only context. PR-URL: #19692 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
Also, move a declaration of unrelated variable closer to its only context. PR-URL: #19692 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAlso, move a declaration of unrelated variable closer to its only context.
Generated doc set is identical after this change.